-
Notifications
You must be signed in to change notification settings - Fork 551
ci(workflows): add PyPI publishing workflow with manual approval #1428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add publish-pypi-approval.yml workflow that triggers after successful builds on version tags. Includes manual approval gate, version validation, PyPI publishing via trusted publishing, draft GitHub release creation, and installation verification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a PyPI publishing workflow that triggers automatically after successful builds on version tags, with manual approval gates for production deployment. The workflow validates versions, publishes to PyPI using trusted publishing, creates draft GitHub releases, and verifies successful publication.
Key changes:
- Automated PyPI publishing triggered by successful build workflows on version tags
- Manual approval environment gate for production deployments
- Post-publish verification testing across Python versions
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left some comments below. How did you test this? Can you add the commands and output to the PR description.
|
@tgasser-nv we will see how it works in prod. Testing it is not possible. We could try test.pypi.org but to simulate the complete scenario wouldn't be worth the effort. we can merge and see how it works in action. What do you think? |
* ci(workflows): add PyPI publishing workflow with manual approval Add publish-pypi-approval.yml workflow that triggers after successful builds on version tags. Includes manual approval gate, version validation, PyPI publishing via trusted publishing, draft GitHub release creation.
* ci(workflows): add PyPI publishing workflow with manual approval Add publish-pypi-approval.yml workflow that triggers after successful builds on version tags. Includes manual approval gate, version validation, PyPI publishing via trusted publishing, draft GitHub release creation.
* ci(workflows): add PyPI publishing workflow with manual approval Add publish-pypi-approval.yml workflow that triggers after successful builds on version tags. Includes manual approval gate, version validation, PyPI publishing via trusted publishing, draft GitHub release creation.
Add publish-pypi-approval.yml workflow that triggers after successful builds on version tags. Includes manual approval gate, version validation, PyPI publishing via trusted publishing, draft GitHub release creation, and installation verification.