Skip to content

Conversation

@Pouyanpi
Copy link
Collaborator

Add publish-pypi-approval.yml workflow that triggers after successful builds on version tags. Includes manual approval gate, version validation, PyPI publishing via trusted publishing, draft GitHub release creation, and installation verification.

Add publish-pypi-approval.yml workflow that triggers after successful
builds on version tags. Includes manual approval gate, version
validation, PyPI publishing via trusted publishing, draft GitHub release
creation, and installation verification.
@Pouyanpi Pouyanpi requested a review from Copilot September 30, 2025 19:26
@Pouyanpi Pouyanpi self-assigned this Sep 30, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a PyPI publishing workflow that triggers automatically after successful builds on version tags, with manual approval gates for production deployment. The workflow validates versions, publishes to PyPI using trusted publishing, creates draft GitHub releases, and verifies successful publication.

Key changes:

  • Automated PyPI publishing triggered by successful build workflows on version tags
  • Manual approval environment gate for production deployments
  • Post-publish verification testing across Python versions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Pouyanpi Pouyanpi marked this pull request as draft September 30, 2025 19:29
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@tgasser-nv tgasser-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left some comments below. How did you test this? Can you add the commands and output to the PR description.

@Pouyanpi
Copy link
Collaborator Author

Pouyanpi commented Oct 2, 2025

@tgasser-nv we will see how it works in prod. Testing it is not possible. We could try test.pypi.org but to simulate the complete scenario wouldn't be worth the effort. we can merge and see how it works in action. What do you think?

@Pouyanpi Pouyanpi marked this pull request as ready for review October 8, 2025 14:45
@Pouyanpi Pouyanpi merged commit 3a2680e into develop Oct 8, 2025
2 checks passed
@Pouyanpi Pouyanpi deleted the ci/pypi-publish-approval branch October 8, 2025 14:54
tgasser-nv pushed a commit that referenced this pull request Oct 14, 2025
* ci(workflows): add PyPI publishing workflow with manual approval

Add publish-pypi-approval.yml workflow that triggers after successful builds on version tags. Includes manual approval gate, version validation, PyPI publishing via trusted publishing, draft GitHub release creation.
tgasser-nv pushed a commit that referenced this pull request Oct 14, 2025
* ci(workflows): add PyPI publishing workflow with manual approval

Add publish-pypi-approval.yml workflow that triggers after successful builds on version tags. Includes manual approval gate, version validation, PyPI publishing via trusted publishing, draft GitHub release creation.
tgasser-nv pushed a commit that referenced this pull request Oct 14, 2025
* ci(workflows): add PyPI publishing workflow with manual approval

Add publish-pypi-approval.yml workflow that triggers after successful builds on version tags. Includes manual approval gate, version validation, PyPI publishing via trusted publishing, draft GitHub release creation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants